linux-kernel - Re: [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWif0YQ/5EFbrA2X@kuha.fi.intel.com>
Date:   Thu, 30 Nov 2023 16:44:33 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of
 pci_alloc_irq_vectors()

On Thu, Nov 30, 2023 at 04:32:06PM +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
> 
> Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
> Reported-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks for the quick fix.

Tested-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/mfd/intel-lpss-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 8f5e10817a9c..4621d3950b8f 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
>  		return ret;
>  
>  	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> -	if (ret)
> +	if (ret < 0)
>  		return ret;
>  
>  	info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);

thanks,

-- 
heikki