[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231130-power-rubbed-fbf64a8c6978@spud>
Date: Thu, 30 Nov 2023 14:58:41 +0000
From: Conor Dooley <conor@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu,
michal.simek@...inx.com, git@...inx.com,
Conor Dooley <conor+dt@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Jean Delvare <jdelvare@...e.com>,
Jonathan Cameron <jic23@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels
On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote:
> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels
> that's why increase it.
> But AMS binding defines 51 channels
> Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> that's why increase number to 51.
Please write commit messages for bindings in terms of how they relate to
some hardware. In this case I think it would be sufficient to say that
the Analog Monitoring system has 51 channels, the opening sentence about
the dts as justification provides no actionable information.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Cheers,
Conor.
> Signed-off-by: Michal Simek <michal.simek@....com>
> ---
>
> Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> index e5b24782f448..be5c7d4579bb 100644
> --- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> @@ -19,7 +19,7 @@ properties:
>
> io-channels:
> minItems: 1
> - maxItems: 8 # Should be enough
> + maxItems: 51 # Should be enough
> description: >
> List of phandles to ADC channels to read the monitoring values
>
> --
> 2.36.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists