linux-kernel - Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f01e7e91-08f1-4548-8e73-aa931d5b4834@intel.com>
Date:   Thu, 30 Nov 2023 17:01:23 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Michal Kubiak <michal.kubiak@...el.com>,
        Larysa Zaremba <larysa.zaremba@...el.com>,
        Alexander Duyck <alexanderduyck@...com>,
        Yunsheng Lin <linyunsheng@...wei.com>,
        "David Christensen" <drc@...ux.vnet.ibm.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        "Paul Menzel" <pmenzel@...gen.mpg.de>, <netdev@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 29 Nov 2023 06:29:14 -0800

> On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote:
>>> Expand the libie generic per-queue stats with the generic Page Pool
>>> stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is
>>> enabled. When it's not, there'll be no such fields in the stats
>>> structure, so no space wasted.  
>>
>> Do I get it correctly that after Page Pool Netlink introspection was
>> merged, this commit makes no sense and we shouln't add PP stats to the
>> drivers private ones?
> 
> Yes, 100%.

Meh, this way the stats won't survive ifdown/ifup cycles as usually
page_pools get destroyed on ifdown :z
In that patch, I backup the PP stats to a device-lifetime container when
the pool gets destroyed, maybe we could do something similar?

> 
> FWIW I am aware that better tooling would be good so non-developers
> could access to the PP Netlink :(  I'm thinking we should clean up 
> YNL lib packaging a little and try to convince iproute2 maintainers 
> to accept simple CLI built on top of it.

Thanks,
Olek