linux-kernel - Re: [PATCH 6/7] serial: max310x: add macro for max number of ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddbc67dd-f8a3-4a6a-954a-bee49260ecab@cesnet.cz>
Date:   Fri, 01 Dec 2023 16:59:12 +0100
From:   Jan Kundrát <jan.kundrat@...net.cz>
To:     Hugo Villeneuve <hugo@...ovil.com>
Cc:     <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <hvilleneuve@...onoff.com>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 6/7] serial: max310x: add macro for max number of ports

On čtvrtek 30. listopadu 2023 20:10:48 CET, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
>
> Add macro to hold the maximum number of UART ports per IC/device.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>

Reviewed-by: Jan Kundrát <jan.kundrat@...net.cz>
Tested-by: Jan Kundrát <jan.kundrat@...net.cz>

> ---
>  drivers/tty/serial/max310x.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> index f3a99daebdaa..58dd5cc62014 100644
> --- a/drivers/tty/serial/max310x.c
> +++ b/drivers/tty/serial/max310x.c
> @@ -30,6 +30,7 @@
>  #define MAX310X_MAJOR			204
>  #define MAX310X_MINOR			209
>  #define MAX310X_UART_NRMAX		16
> +#define MAX310X_MAX_PORTS		4 /* Maximum number of UART ports per IC. */
>  
>  /* MAX310X register definitions */
>  #define MAX310X_RHR_REG			(0x00) /* RX FIFO */
> @@ -1502,7 +1503,7 @@ static const struct max310x_if_cfg 
> __maybe_unused max310x_spi_if_cfg = {
>  static int max310x_spi_probe(struct spi_device *spi)
>  {
>  	const struct max310x_devtype *devtype;
> -	struct regmap *regmaps[4];
> +	struct regmap *regmaps[MAX310X_MAX_PORTS];
>  	unsigned int i;
>  	int ret;
>  
> @@ -1605,7 +1606,7 @@ static int max310x_i2c_probe(struct 
> i2c_client *client)
>  	const struct max310x_devtype *devtype =
>  			device_get_match_data(&client->dev);
>  	struct i2c_client *port_client;
> -	struct regmap *regmaps[4];
> +	struct regmap *regmaps[MAX310X_MAX_PORTS];
>  	unsigned int i;
>  	u8 port_addr;
>