linux-kernel - Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <acb94c6918cf9f212d0d9fadd414e66e132b5e11.camel@mediatek.com>
Date:   Fri, 1 Dec 2023 01:59:38 +0000
From:   CK Hu (胡俊光) <ck.hu@...iatek.com>
To:     Mac Shen (沈俊) <Mac.Shen@...iatek.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        Jitao Shi (石记涛) <jitao.shi@...iatek.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "airlied@...il.com" <airlied@...il.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Shuijing Li (李水静) 
        <Shuijing.Li@...iatek.com>
Subject: Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
> 
> Signed-off-by: mac.shen <mac.shen@...iatek.com>
> ---
>  drivers/gpu/drm/mediatek/Makefile         |    7 +-
>  drivers/gpu/drm/mediatek/ca/tci.h         |  143 +++
>  drivers/gpu/drm/mediatek/ca/tlDPHdcpCMD.h |   36 +
>  drivers/gpu/drm/mediatek/ca/tlcDpHdcp.c   |  638 +++++++++++++
>  drivers/gpu/drm/mediatek/ca/tlcDpHdcp.h   |  305 +++++++
>  drivers/gpu/drm/mediatek/mtk_dp.c         |  159 +++-
>  drivers/gpu/drm/mediatek/mtk_dp.h         |   17 +
>  drivers/gpu/drm/mediatek/mtk_dp_hdcp.h    |  154 ++++
>  drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.c  |  646 +++++++++++++
>  drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.h  |   55 ++
>  drivers/gpu/drm/mediatek/mtk_dp_hdcp2.c   | 1008
> +++++++++++++++++++++
>  drivers/gpu/drm/mediatek/mtk_dp_hdcp2.h   |   75 ++
>  drivers/gpu/drm/mediatek/mtk_dp_reg.h     |    6 +-
>  13 files changed, 3233 insertions(+), 16 deletions(-)
>  create mode 100644 drivers/gpu/drm/mediatek/ca/tci.h
>  create mode 100644 drivers/gpu/drm/mediatek/ca/tlDPHdcpCMD.h
>  create mode 100644 drivers/gpu/drm/mediatek/ca/tlcDpHdcp.c
>  create mode 100644 drivers/gpu/drm/mediatek/ca/tlcDpHdcp.h
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.h
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp.h
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.c
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.h
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp2.c
>  create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp2.h
> 

[snip]

> +
> +struct cryptokeys_t {
> +	u8 type;
> +	u32 len;
> +	u32 key;
> +};

Useless, so remove it.

> +
> +struct cmd_hdcp_init_for_verion_t {
> +	u32 version;
> +	bool need_load_key;
> +};
> +
> +struct cmd_hdcp_write_val_t {
> +	u8 type;
> +	u8 len;
> +	u32 val;
> +};
> +
> +struct cmd_hdcp_calculate_lm_t {
> +	u8 bksv[BKSV_LEN];
> +};
> +
> +struct cmd_hdcp_get_aksv_t {
> +	u8 aksv[AKSV_LEN];
> +};
> +
> +struct cmd_hdcp_sha1_t {
> +	u32 message_len;
> +	u32 message_addr;
> +};

Useless, so remove it.

Regards,
CK

> +
> +struct cmd_hdcp_ake_certificate_t {
> +	u8 certification[CERT_LEN];
> +	bool stored;
> +	u8 m[M_LEN];
> +	u8 ekm[EKM_LEN];
> +};
> +
> +struct cmd_hdcp_ake_paring_t {
> +	u8 ekm[EKM_LEN];
> +};
> +
> +struct cmd_hdcp_enc_km_t {
> +	u8 enc_km[ENC_KM_LEN];
> +};
> +