linux-kernel - Re: [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix example regulator node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZWoOaRLZGXMhwC_r@hovoldconsulting.com>
Date:   Fri, 1 Dec 2023 17:48:41 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh@...nel.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        Lee Jones <lee@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix
 example regulator node

On Fri, Dec 01, 2023 at 03:42:38PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 15:40, Rob Herring wrote:
> > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
> >> The example regulator child nodes do not have unit addresses so drop the
> >> incorrect '#address-cells' and '#size-cells' properties from the parent
> >> node.
 
> >>        regulators {
> >> -        #address-cells = <1>;
> >> -        #size-cells = <0>;
> >> -
> > 
> > It's the right fix, but I have to wonder why these are not schema 
> > errors? Seems like something in the schemas needs fixing.
> 
> Good point. The fix is just not sufficient.  This binding explicitly
> allow it, so it should be removed there as well.

Ah, I missed that. Now fixed up in v2.

Johan