linux-kernel - Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202312010945.7C5DB1FBB@keescook>
Date:   Fri, 1 Dec 2023 09:47:42 -0800
From:   Kees Cook <keescook@...omium.org>
To:     sxwjean@...com
Cc:     vbabka@...e.cz, 42.hyeyoo@...il.com, cl@...ux.com,
        linux-mm@...ck.org, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, roman.gushchin@...ux.dev, corbet@....net,
        arnd@...db.de, akpm@...ux-foundation.org,
        gregkh@...uxfoundation.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Xiongwei Song <xiongwei.song@...driver.com>
Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with
 "slab_$param"

On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@...com wrote:
> From: Xiongwei Song <xiongwei.song@...driver.com>
> 
> Since the SLAB allocator has been removed, so we need to clean up the
> sl[au]b_$params. However, the "slab/SLAB" terms should be keep for
> long-term rather than "slub/SLUB". Hence, we should use "slab_$param"
> as the primary prefix, which is pointed out by Vlastimil Babka. For more
> information please see [1].
> 
> This patch is changing the following slab parameters
> - slub_max_order
> - slub_min_order
> - slub_min_objects
> - slub_debug
> to
> - slab_max_order
> - slab_min_order
> - slab_min_objects
> - slab_debug
> as the primary slab parameters in
> Documentation/admin-guide/kernel-parameters.txt and source, and rename all
> setup functions of them too. Meanwhile, "slub_$params" can also be passed
> by command line, which is to keep backward compatibility. Also mark all
> "slub_$params" as legacy.

*If* we do this, I think the old names need to be recognized, perhaps
with a boot pr_warn() about their deprecation/renaming for several
releases (likely across LTSes). I think it's not a good idea to
wholesale rename these with no warning. That's going to cause a lot of
surprises and broken userspace...

-- 
Kees Cook