linux-kernel - Re: Non-existing CONFIG_ options are used in source code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231201185112.1499c5ab@barney>
Date:   Fri, 1 Dec 2023 18:51:12 +0100
From:   Michael Büsch <m@...s.ch>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     sunying@...c.iscas.ac.cn, linux-kernel@...r.kernel.org,
        Neal Liu <neal_liu@...eedtech.com>,
        David Howells <dhowells@...hat.com>,
        linux-crypto@...r.kernel.org,
        "pengpeng@...as.ac.cn" <pengpeng@...as.ac.cn>,
        "renyanjie01@...il.com" <renyanjie01@...il.com>
Subject: Re: Non-existing CONFIG_ options are used in source code

On Mon, 13 Nov 2023 20:52:03 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> On 9/13/23 02:29, sunying@...c.iscas.ac.cn wrote:
> > The following configuration options are not defined
> >  (they may have been deleted or not yet added)
> >  but are used in the source files.
> > 
> > Is there something in these that might need fixing?
> > 
> > ===============================================
> > 1. CONFIG_NETFS_DEBUG
> > fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
> > 
> > 2. CONFIG_SSB_DEBUG
> > include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
> > 
> > 3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef
> > CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > ===============================================  
> 
> Yes, please send separate patches to remove each of them.

I agree for CONFIG_SSB_DEBUG.

The function __ssb_dma_not_implemented() where CONFIG_SSB_DEBUG is used
can be removed and the switch-default where __ssb_dma_not_implemented()
is called can also be removed.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped