linux-kernel - Re: [PATCH] x86/MCE: Get microcode revision from cpu_data instead of boot_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231201185922.GEZWotChARf77oe3iL@fat_crate.local>
Date:   Fri, 1 Dec 2023 19:59:22 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Filippo Sironi <sironi@...zon.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-edac@...g.kernel.org, tony.luck@...el.com,
        tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
        hpa@...or.com
Subject: Re: [PATCH] x86/MCE: Get microcode revision from cpu_data instead of
 boot_cpu_data

On Fri, Dec 01, 2023 at 11:23:27AM +0000, Filippo Sironi wrote:
> Unfortunately, boot_cpu_data isn't updated on late microcode loading,

Looks good to me here:

[   50.881231] microcode: Unsafe microcode update: Microcode header does not specify a required min version
[   50.892577] microcode: Late microcode loading without minimal revision check.
[   50.900099] microcode: You should switch to early loading, if possible.
[   50.958919] microcode: load: updated on 6 primary CPUs with 0 siblings
[   50.965856] microcode: revision: 0xbe -> 0xf0

That comes from:

	pr_info("revision: 0x%x -> 0x%x\n", old_rev, boot_cpu_data.microcode);

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette