linux-kernel - Re: [PATCH] scsi: libsas: Put the disk offline if all recovery actions fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bc81cf1-5d94-c108-a107-a746daadb64d@huawei.com>
Date:   Fri, 1 Dec 2023 10:59:56 +0800
From:   yangxingui <yangxingui@...wei.com>
To:     <john.g.garry@...cle.com>, <yanaijie@...wei.com>,
        <damien.lemoal@...nsource.wdc.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <wubo40@...wei.com>, <kangfenglong@...wei.com>
Subject: Re: [PATCH] scsi: libsas: Put the disk offline if all recovery
 actions fail

Sorry, please ignore this email, I need to update a new version, Thanks.

On 2023/11/30 21:01, Xingui Yang wrote:
> Currently, after all recovery actions in sas_eh_handle_sas_errors() fail
> for sas disk, we just clear all IO, but the disk is still online. Perhaps
> we should continue the subsequent recovery process for IO that cannot be
> processed. If it still fails, the disk will be offline in
> scsi_eh_ready_devs().
> 
> Signed-off-by: Xingui Yang <yangxingui@...wei.com>
> Signed-off-by: Bo Wu <wubo40@...wei.com>
> ---
>   drivers/scsi/libsas/sas_scsi_host.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index 9047cfcd1072..3f9b99fa1769 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -637,8 +637,8 @@ static void sas_eh_handle_sas_errors(struct Scsi_Host *shost, struct list_head *
>   			       SAS_ADDR(task->dev->sas_addr),
>   			       cmd->device->lun);
>   
> -			sas_eh_finish_cmd(cmd);
> -			goto clear_q;
> +			list_move_tail(&cmd->eh_entry, work_q);
> +			goto out;
>   		}
>   	}
>    out:
>