linux-kernel - Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d426976d-4446-40a0-9088-82d9f4ebb950@redhat.com>
Date:   Fri, 1 Dec 2023 21:18:21 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely()

On 01.12.23 21:15, Steven Rostedt wrote:
> On Fri, 1 Dec 2023 21:06:22 +0100
> David Hildenbrand <david@...hat.com> wrote:
> 
>> But
>>
>>> Cc: stable@...r.kernel.org
>>
>> stable, really? Why?
>>
>>> Fixes:fb3d824d1a46c ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap()")
>>
>> and does it even fix a real bug?
> 
> As a performance person, who measures likely and unlikely results (the
> ftrace ring buffer was sped up by over 50% with strategically placed
> likely/unlikely annotation). I find this to be a real bug, and something I
> would want backported to the kernels we maintain in ChromeOS (which uses
> upstream stable kernels).

Okay, I don't care that much about a "Fixes" annotation.

But I am *pretty* sure that this is not stable material, looking once 
again at the stable rules.

Anyhow, thanks for catching this!

-- 
Cheers,

David / dhildenb