linux-kernel - Re: [PATCH v3 4/4] clk: qcom: videocc-sm8150: Add runtime PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1604d9c-663a-4778-87e6-53f8e4b8b25e@linaro.org>
Date:   Fri, 1 Dec 2023 22:45:49 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Marek <jonathan@...ek.ca>
Cc:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] clk: qcom: videocc-sm8150: Add runtime PM support

On 1.12.2023 10:50, Satya Priya Kakitapalli wrote:
> Add runtime PM support to ensure the supply rails are enabled
> when necessary.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  	clk_trion_pll_configure(&video_pll0, regmap, &video_pll0_config);
>  
>  	/* Keep VIDEO_CC_XO_CLK ALWAYS-ON */
>  	regmap_update_bits(regmap, 0x984, 0x1, 0x1);
>  
> -	return qcom_cc_really_probe(pdev, &video_cc_sm8150_desc, regmap);
> +	ret = qcom_cc_really_probe(pdev, &video_cc_sm8150_desc, regmap);
> +
> +	pm_runtime_put_sync(&pdev->dev);
> +
> +	return ret;
>  }
>  
>  static struct platform_driver video_cc_sm8150_driver = {
>