linux-kernel - Re: [PATCH 1/2] net: phy: micrel: use devm_clk_get_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfa25436-305e-4cdb-a6d0-55fcc45322f6@lunn.ch>
Date:   Fri, 1 Dec 2023 23:19:35 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        quentin.schulz@...obroma-systems.com,
        Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH 1/2] net: phy: micrel: use devm_clk_get_optional_enabled
 for the rmii-ref clock

On Fri, Dec 01, 2023 at 04:01:30PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> While the external clock input will most likely be enabled, it's not
> guaranteed and clk_get_rate in some suppliers will even just return
> valid results when the clock is running.
> 
> So use devm_clk_get_optional_enabled to retrieve and enable the clock
> in one go.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew