linux-kernel - [PATCH v2 3/6] ptp/vmware: Use vmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231201232452.220355-4-amakhalov@vmware.com>
Date:   Fri,  1 Dec 2023 15:24:49 -0800
From:   Alexey Makhalov <amakhalov@...are.com>
To:     linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
        hpa@...or.com, dave.hansen@...ux.intel.co, bp@...en8.d,
        mingo@...hat.com, tglx@...utronix.de
Cc:     x86@...nel.org, netdev@...r.kernel.org, richardcochran@...il.com,
        linux-input@...r.kernel.org, dmitry.torokhov@...il.com,
        zackr@...are.com, linux-graphics-maintainer@...are.com,
        pv-drivers@...are.com, namit@...are.com, timothym@...are.com,
        akaher@...are.com, jsipek@...are.com,
        dri-devel@...ts.freedesktop.org, daniel@...ll.ch,
        airlied@...il.com, tzimmermann@...e.de, mripard@...nel.org,
        maarten.lankhorst@...ux.intel.com, horms@...nel.org
Subject: [PATCH v2 3/6] ptp/vmware: Use vmware_hypercall API

Switch from VMWARE_HYPERCALL macro to vmware_hypercall API.
Eliminate arch specific code. No functional changes intended.

Signed-off-by: Alexey Makhalov <amakhalov@...are.com>
Reviewed-by: Nadav Amit <namit@...are.com>
Reviewed-by: Jeff Sipek <jsipek@...are.com>
---
 drivers/ptp/ptp_vmw.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/ptp/ptp_vmw.c b/drivers/ptp/ptp_vmw.c
index 27c5547aa8a9..e5bb521b9b82 100644
--- a/drivers/ptp/ptp_vmw.c
+++ b/drivers/ptp/ptp_vmw.c
@@ -14,7 +14,6 @@
 #include <asm/hypervisor.h>
 #include <asm/vmware.h>
 
-#define VMWARE_MAGIC 0x564D5868
 #define VMWARE_CMD_PCLK(nr) ((nr << 16) | 97)
 #define VMWARE_CMD_PCLK_GETTIME VMWARE_CMD_PCLK(0)
 
@@ -24,15 +23,10 @@ static struct ptp_clock *ptp_vmw_clock;
 
 static int ptp_vmw_pclk_read(u64 *ns)
 {
-	u32 ret, nsec_hi, nsec_lo, unused1, unused2, unused3;
-
-	asm volatile (VMWARE_HYPERCALL :
-		"=a"(ret), "=b"(nsec_hi), "=c"(nsec_lo), "=d"(unused1),
-		"=S"(unused2), "=D"(unused3) :
-		"a"(VMWARE_MAGIC), "b"(0),
-		"c"(VMWARE_CMD_PCLK_GETTIME), "d"(0) :
-		"memory");
+	u32 ret, nsec_hi, nsec_lo;
 
+	ret = vmware_hypercall3(VMWARE_CMD_PCLK_GETTIME, 0,
+				&nsec_hi, &nsec_lo);
 	if (ret == 0)
 		*ns = ((u64)nsec_hi << 32) | nsec_lo;
 	return ret;
-- 
2.39.0