linux-kernel - Re: [PATCH] cgroup: Fix documentation for cpu.idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWlzwnO7PcOWQ2q_@archie.me>
Date:   Fri, 1 Dec 2023 12:48:50 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Josh Don <joshdon@...gle.com>, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Jonathan Corbet <corbet@....net>
Cc:     Linux CGroups <cgroups@...r.kernel.org>,
        Linux Documentation <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Attreyee M <tintinm2017@...il.com>
Subject: Re: [PATCH] cgroup: Fix documentation for cpu.idle

On Thu, Nov 30, 2023 at 04:52:03PM -0800, Josh Don wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 3f85254f3cef..9debf02bcb39 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1093,7 +1093,11 @@ All time durations are in microseconds.
>  	A read-write single value file which exists on non-root
>  	cgroups.  The default is "100".
>  
> -	The weight in the range [1, 10000].
> +	For non idle groups (cpu.idle = 0), the weight is in the
> +	range [1, 10000].
> +
> +	If the cgroup has been configured to be SCHED_IDLE (cpu.idle = 1),
> +	then the weight will show as a 0.

This one LGTM.

>  
>    cpu.weight.nice
>  	A read-write single value file which exists on non-root
> @@ -1157,6 +1161,16 @@ All time durations are in microseconds.
>          values similar to the sched_setattr(2). This maximum utilization
>          value is used to clamp the task specific maximum utilization clamp.
>  
> +  cpu.idle
> +	A read-write single value file which exists on non-root cgroups.
> +	The default is 0.
> +
> +	This is the cgroup analog of the per-task SCHED_IDLE sched policy.
"... cgroup analogy to ..."
> +	Setting this value to a 1 will make the scheduling policy of the
> +	cgroup SCHED_IDLE. The threads inside the cgroup will retain their
> +	own relative priorities, but the cgroup itself will be treated as
> +	very low priority relative to its peers.
> +
>  

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)