linux-kernel - Re: [PATCH -next] media: chips-media: VIDEO_WAVE_VPU should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2023 00:11:12 -0600
From:   Nishanth Menon <nm@...com>
To:     Sebastian Fricke <sebastian.fricke@...labora.com>
CC:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Nas Chung <nas.chung@...psnmedia.com>,
        Jackson Lee <jackson.lee@...psnmedia.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Beckett <bob.beckett@...labora.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, <linux-media@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] media: chips-media: VIDEO_WAVE_VPU should depend
 on ARCH_K3

On 11:07-20231130, Sebastian Fricke wrote:
> Hey Geert,
> 
> Thanks for the patch!
> 
> Could you please adjust the subject line to:
> media: chips-media: wave5: VIDEO_WAVE_VPU should depend on ARCH_K3
>                     ^^^^^^
> 
> On 28.11.2023 19:26, Geert Uytterhoeven wrote:
> > The Chips&Media Wave 5 Series multi-standard codec IP is currently only
> > supported on Texas Instruments K3 J721S2 SoC.  Hence add a dependency on
> 
> While it is true that is currently only tested on the K3 architecture ,
> it is not only supported by that exact SoC, as you can see here:
> https://lore.kernel.org/all/20231127223718.2651185-4-b-brnich@ti.com/T/
> 
> So, maybe this commit is worded better with:
> 
> is currently only supported on the Texas Instruments K3 architecture.
> 
> The change however is obviously correct.
> 
> Greetings,
> Sebastian
> 
> > ARCH_K3, to prevent asking the user about this driver when configuring a
> > kernel without Texas Instruments K3 Multicore SoC support.
> > 
> > Fixes: 9707a6254a8a6b97 ("media: chips-media: wave5: Add the v4l2 layer")

Thank you Sebastian, in addition, a nitpick: checkpatch.pl complains:
Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")'
https://docs.kernel.org/process/submitting-patches.html
Quote:

If your patch fixes a bug in a specific commit, e.g. you found an
issue using git bisect, please use the 'Fixes:' tag with the first 12
characters of the SHA-1 ID, and the one line summary. Do not split
the tag across multiple lines, tags are exempt from the "wrap at 75
columns" rule in order to simplify parsing scripts


with the above fixed, please feel free to add:
Reviewed-by: Nishanth Menon <nm@...com>

> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > drivers/media/platform/chips-media/wave5/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/platform/chips-media/wave5/Kconfig b/drivers/media/platform/chips-media/wave5/Kconfig
> > index 77e7ae5c8f35f454..9ccc1f7e32f3874f 100644
> > --- a/drivers/media/platform/chips-media/wave5/Kconfig
> > +++ b/drivers/media/platform/chips-media/wave5/Kconfig
> > @@ -3,6 +3,7 @@ config VIDEO_WAVE_VPU
> > 	tristate "Chips&Media Wave Codec Driver"
> > 	depends on V4L_MEM2MEM_DRIVERS
> > 	depends on VIDEO_DEV && OF
> > +	depends on ARCH_K3 || COMPILE_TEST
> > 	select VIDEOBUF2_DMA_CONTIG
> > 	select VIDEOBUF2_VMALLOC
> > 	select V4L2_MEM2MEM_DEV

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D