linux-kernel - Re: [PATCH v2 00/11] drm/tidss: Probe related fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <482d9ad7-86b6-48a9-8dab-5502ce1a5384@ti.com>
Date:   Fri, 1 Dec 2023 11:54:04 +0530
From:   Aradhya Bhatia <a-bhatia1@...com>
To:     Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
        Devarsh Thakkar <devarsht@...com>,
        Jyri Sarha <jyri.sarha@....fi>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Francesco Dolcini <francesco@...cini.it>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v2 00/11] drm/tidss: Probe related fixes and cleanups

Hi Tomi,

Thank you for the patches!

On 09/11/23 13:07, Tomi Valkeinen wrote:
> While working on the TI BSP kernel, adding bootload splash screen
> support, I noticed some issues with the driver and opportunities for
> cleanups and improvements.
> 
>  Tomi
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> ---
> Changes in v2:
> - Add missing pm_runtime_dont_use_autosuspend() in error path
> - Add simple manual "reset" for K2G
> - Leave tidss->dispc NULL if dispc_init fails
> - Add Fixes tags
> - Drop "drm/tidss: Add dispc_is_idle()"
> - Add "drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY"
> - Link to v1: https://lore.kernel.org/r/20231101-tidss-probe-v1-0-45149e0f9415@ideasonboard.com
> 
> ---
> Tomi Valkeinen (11):
>       drm/tidss: Use pm_runtime_resume_and_get()
>       drm/tidss: Use PM autosuspend
>       drm/tidss: Drop useless variable init
>       drm/tidss: Move reset to the end of dispc_init()
>       drm/tidss: Return error value from from softreset
>       drm/tidss: Check for K2G in in dispc_softreset()
>       drm/tidss: Add simple K2G manual reset
>       drm/tidss: Fix dss reset
>       drm/tidss: IRQ code cleanup
>       drm/tidss: Fix atomic_flush check
>       drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY

For the series,

Reviewed-by: Aradhya Bhatia <a-bhatia1@...com>

Regards
Aradhya

> 
>  drivers/gpu/drm/tidss/tidss_crtc.c  | 12 ++----
>  drivers/gpu/drm/tidss/tidss_dispc.c | 79 +++++++++++++++++++++++++++++++++----
>  drivers/gpu/drm/tidss/tidss_drv.c   | 15 +++++--
>  drivers/gpu/drm/tidss/tidss_irq.c   | 54 ++++---------------------
>  drivers/gpu/drm/tidss/tidss_kms.c   |  2 +-
>  5 files changed, 97 insertions(+), 65 deletions(-)
> ---
> base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
> change-id: 20231030-tidss-probe-854b1098c3af
> 
> Best regards,