linux-kernel - Re: [PATCH] crypto: asymmetric_keys/pkcs7.asn1 - remove the duplicated contentType pkcs7_note

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99c010f0-3bb1-1e67-4184-6b0ce312b232@linux.alibaba.com>
Date:   Fri, 1 Dec 2023 15:44:41 +0800
From:   "YiLin.Li" <YiLin.Li@...ux.alibaba.com>
To:     David Howells <dhowells@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     tianjia.zhang@...ux.alibaba.com, YiLin.Li@...ux.alibaba.com
Subject: Re: [PATCH] crypto: asymmetric_keys/pkcs7.asn1 - remove the
 duplicated contentType pkcs7_note_OID processing logic


gently ping...
> The OID of contentType has been recorded in
> `ContentType ::= OBJECT IDENTIFIER ({ pkcs7_note_OID })`,
> so there is no need to re-extract the OID of contentType in
> `contentType ContentType ({ pkcs7_note_OID })`.
> Therefore, we need to remove the duplicated contentType
> pkcs7_note_OID processing logic.
>
> Signed-off-by: YiLin.Li <YiLin.Li@...ux.alibaba.com>
> ---
>   crypto/asymmetric_keys/pkcs7.asn1 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/pkcs7.asn1 b/crypto/asymmetric_keys/pkcs7.asn1
> index 28e1f4a41c14..3f7adec38245 100644
> --- a/crypto/asymmetric_keys/pkcs7.asn1
> +++ b/crypto/asymmetric_keys/pkcs7.asn1
> @@ -28,7 +28,7 @@ SignedData ::= SEQUENCE {
>   }
>   
>   ContentInfo ::= SEQUENCE {
> -	contentType	ContentType ({ pkcs7_note_OID }),
> +	contentType	ContentType,
>   	content		[0] EXPLICIT Data OPTIONAL
>   }
>