linux-kernel - RE: [PATCH net-next] octeon_ep: Fix error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR1801MB19828A129D67109B97458B2FD881A@MWHPR1801MB1982.namprd18.prod.outlook.com>
Date:   Fri, 1 Dec 2023 08:55:05 +0000
From:   Sathesh B Edara <sedara@...vell.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Shinas Rasheed <srasheed@...vell.com>
CC:     Veerasenareddy Burru <vburru@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net-next] octeon_ep: Fix error code in probe()



-----Original Message-----
From: Dan Carpenter <dan.carpenter@...aro.org> 
Sent: Tuesday, November 28, 2023 6:43 PM
To: Shinas Rasheed <srasheed@...vell.com>
Cc: Veerasenareddy Burru <vburru@...vell.com>; Sathesh B Edara <sedara@...vell.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
Subject: [PATCH net-next] octeon_ep: Fix error code in probe()

----------------------------------------------------------------------
Set the error code if octep_ctrl_net_get_mtu() fails.  Currently the code returns success.

Fixes: 0a5f8534e398 ("octeon_ep: get max rx packet length from firmware")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
 drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
index 423eec5ff3ad..f2e5c7d80398 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
@@ -1383,6 +1383,7 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (max_rx_pktlen < 0) {
 		dev_err(&octep_dev->pdev->dev,
 			"Failed to get max receive packet size; err = %d\n", max_rx_pktlen);
+		err = max_rx_pktlen;
 		goto register_dev_err;
 	}
 	netdev->min_mtu = OCTEP_MIN_MTU;
--
2.42.0
Reviewed-by: Sathesh B Edara <sedara@...vell.com>