linux-kernel - Re: [RESEND PATCH] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWmhKS+quI3dmOND@moxa-ThinkCentre-M90t>
Date:   Fri, 1 Dec 2023 17:02:33 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@...a.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [RESEND PATCH] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe
 boards not work by default

On Fri, Dec 01, 2023 at 08:27:05AM +0000, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2023 at 03:40:55PM +0800, Crescent CY Hsieh wrote:
> > MOXA PCIe RS422/RS485 boards will not function by default because of the
> > initial default serial interface of all MOXA PCIe boards is set to
> > RS232.
> > 
> > This patch fixes the problem above by setting the initial default serial
> > interface to RS422 for those MOXA RS422/RS485 PCIe boards.
> > 
> > Signed-off-by: Crescent CY Hsieh <crescentcy.hsieh@...a.com>
> > Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
> > ---
> >  drivers/tty/serial/8250/8250_pci.c | 58 +++++++++++++++++++++++++++++-
> >  1 file changed, 57 insertions(+), 1 deletion(-)
> 
> Why is this a RESEND?  What happened to the first attempt, did I miss it
> somewhere?

This RESEND patch is the first patch of this patch series [1], Jiri
reviewed the first patch and suggested to split the second patch, so I
split the second patch and sent it as a new patch.

However, the first patch seems to be overlooked, so I resend it.

[1] https://lore.kernel.org/all/20231027062440.7749-1-crescentcy.hsieh@moxa.com/

---
Sincerely,
Crescent CY Hsieh