linux-kernel - Re: [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2023 11:40:19 +0100
From:   Francesco Dolcini <francesco@...cini.it>
To:     David Lin <yu-hao.lin@....com>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        briannorris@...omium.org, kvalo@...nel.org, francesco@...cini.it,
        tsung-hsien.hsieh@....com
Subject: Re: [PATCH v7 11/12] wifi: mwifiex: misc modifications for review
 comments.

On Tue, Nov 28, 2023 at 04:31:14PM +0800, David Lin wrote:
> 1. Moved struct mwifiex_ieee80211_mgmt from cfg80211.c to fw.h.
> 2. Defined WLAN_AUTH_NONE instead of using 0xFFFF directly.
> 3. Changed host_mlme of struct mwifiex_adapter to host_mlme_enabled.
> 4. Moved mwifiex_check_key_api_ver() to end of mwifiex_ret_get_hw_spec().
> 5. Redefined MWIFIEX_MGMT_HEADER_LEN and MWIFIEX_AUTH_BODY_LEN.

You should fix the existing patch, not create a fixup commit on top.

Francesco