linux-kernel - Re: [PATCH] scripts/show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZWnNOswNOP_1_EcH@buildd.core.avm.de>
Date:   Fri, 1 Dec 2023 13:10:34 +0100
From:   Nicolas Schier <n.schier@....de>
To:     Hu Haowen <2023002089@...k.tyut.edu.cn>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        masahiroy@...nel.org, ndesaulniers@...gle.com, ojeda@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/show_delta: reformat code

On Fri, Dec 01, 2023 at 12:56:14PM +0800, Hu Haowen wrote:
> 
> On 2023/12/1 01:13, Miguel Ojeda wrote:
> > On Thu, Nov 30, 2023 at 3:49 PM Hu Haowen <2023002089@...k.tyut.edu.cn> wrote:
> > > -                               if string.find(rest, base_str)==1:
> > > +                               if string.find(rest, base_str) == 1:
> > If this is changed, shouldn't be others like:
> > 
> > >                  if arg=="-b":
> > >                  elif arg=="-h":
> > be changed too?
> 
> 
> Sorry, ignored by accident. I'll make up within the next patch version.
> 
> 
> > In other words, it seems this was done manually. Should we instead
> > introduce/use something like Black or Ruff if we are going to do this
> > sort of changes?
> 
> 
> I'm sorry but I'm not familiar with these two things. Are Black and Ruff
> some kind of tools which help identify these code format issues? If so
> it is better to introduce them to assist to accomplish the similar
> series of work instead of only completing it manually with avoiding
> omitted parts simultaneously.

yes, both are Python code formatters:

Black:
   Documentation: https://black.readthedocs.io/en/stable/
   Repology:      https://repology.org/project/black/

Ruff:
   Documentation: https://docs.astral.sh/ruff/formatter/
   Repology: https://repology.org/project/ruff-python-linter/

Kind regards,
Nicolas