linux-kernel - Re: [RFC PATCH 1/1] locking: introduce devm_mutex_init and devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <070c174c-057a-46de-ae8e-836e9e20eceb@salutedevices.com>
Date:   Fri, 1 Dec 2023 16:43:35 +0300
From:   George Stark <gnstark@...utedevices.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Waiman Long <longman@...hat.com>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <will@...nel.org>,
        <boqun.feng@...il.com>, <jic23@...nel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...utedevices.com>
Subject: Re: [RFC PATCH 1/1] locking: introduce devm_mutex_init and
 devm_mutex_destroy

Andy, Waiman

Thanks for the review.

I'll move the patch to the devm-helpers.h then.


On 11/28/23 19:35, Andy Shevchenko wrote:
> On Mon, Nov 27, 2023 at 08:55:18PM -0500, Waiman Long wrote:
>> On 11/27/23 19:09, George Stark wrote:
> 
> ...
> 
>> These APIs are specific to devres. I don't believe it is suitable to put
>> them into the generic mutex.h header file. All devres_* functions are
>> defined in include/linux/device.h which is probabably not included in
>> mutex.h. You may consider putting these APIs into device.h instead.
> 
> +1. We have include/linux/devm-helpers.h.
> 

-- 
Best regards
George