linux-kernel - Re: [PATCH] dt-bindings: marvell: move MMP boards to common marvell directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d511e31-8ff5-4c23-a65e-8660833a9799@lunn.ch>
Date:   Fri, 1 Dec 2023 15:34:09 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lubomir Rintel <lkundrak@...sk>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: marvell: move MMP boards to common marvell
 directory

On Fri, Dec 01, 2023 at 03:21:05PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 14:51, Andrew Lunn wrote:
> > On Fri, Dec 01, 2023 at 02:23:06PM +0100, Krzysztof Kozlowski wrote:
> >> Marvell board bindings are spread over arm/marvell/ and arm/mrvl/
> >> directories.  Move MMP board bindings from the latter to the former, to
> >> keep all of them together.
> > 
> > Hi Krzysztof
> > 
> > Did you test get_maintainers.pl? MMP has a different maintainer to
> > many of the other Marvell SoCs. We want emails going to the correct
> > Maintainers, and ideally not spamming the others.
> 
> The old binding was not referenced in MAINTAINERS, at least I could not
> find it.
> My change does not affect status quo - orphaned files.
> 
> OTOH, some entries like Orion list specific files. Others like Marvell
> list entire directory, which is their mistake in the first place.
> 
> There is a mess in this approach, but the mess exists before my patch.

I think these moved files will now match:

ARM/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SOC support
M:      Andrew Lunn <andrew@...n.ch>
M:      Gregory Clement <gregory.clement@...tlin.com>
M:      Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
L:      linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
S:      Maintained
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git
F:      Documentation/devicetree/bindings/arm/marvell/

But these files are not Gregory or my problem.

If they were orphaned before, i would prefer they are either orphaned
after the move, or associated to the correct maintainer. Being
associated to the wrong maintainers is worse than having no
maintainers at all.

   Andrew