linux-kernel - Re: [PATCH v2 2/4] lib: move pci-specific devres code to drivers/pci/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <32552a65-b540-4baa-9180-e04a278f0ca6@app.fastmail.com>
Date:   Fri, 01 Dec 2023 15:44:44 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Philipp Stanner" <pstanner@...hat.com>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Dan Williams" <dan.j.williams@...el.com>,
        "Jonathan Cameron" <Jonathan.Cameron@...wei.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Dave Jiang" <dave.jiang@...el.com>,
        "Uladzislau Koshchanka" <koshchanka@...il.com>,
        "Neil Brown" <neilb@...e.de>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "John Sanpe" <sanpeqf@...il.com>,
        "Kent Overstreet" <kent.overstreet@...il.com>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        "Kees Cook" <keescook@...omium.org>,
        "David Gow" <davidgow@...gle.com>,
        "Yury Norov" <yury.norov@...il.com>,
        "wuqiang.matt" <wuqiang.matt@...edance.com>,
        "Jason Baron" <jbaron@...mai.com>,
        "Kefeng Wang" <wangkefeng.wang@...wei.com>,
        "Ben Dooks" <ben.dooks@...ethink.co.uk>,
        "Danilo Krummrich" <dakr@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] lib: move pci-specific devres code to drivers/pci/

On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote:
> The pcim_*() functions in lib/devres.c are guarded by an #ifdef
> CONFIG_PCI and, thus, don't belong to this file. They are only ever used
> for pci and are not generic infrastructure.
>
> Move all pcim_*() functions in lib/devres.c to drivers/pci/devres.c.
> Adjust the Makefile.
>
> Suggested-by: Danilo Krummrich <dakr@...hat.com>
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> ---
>  drivers/pci/Makefile |   2 +-
>  drivers/pci/devres.c | 207 ++++++++++++++++++++++++++++++++++++++++++
>  lib/devres.c         | 208 +------------------------------------------

I still think this should go into drivers/pci/pci_iomap.c along
with the other functions.

     Arnd