linux-kernel - Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d720940-5cd1-4d53-bdf2-97334069a5b8@quicinc.com>
Date:   Fri, 1 Dec 2023 07:05:02 -0800
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Francesco Dolcini <francesco@...cini.it>,
        David Lin <yu-hao.lin@....com>
CC:     <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <briannorris@...omium.org>, <kvalo@...nel.org>,
        <tsung-hsien.hsieh@....com>
Subject: Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3.

On 12/1/2023 2:15 AM, Francesco Dolcini wrote:
> On Tue, Nov 28, 2023 at 04:31:05PM +0800, David Lin wrote:

>> diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
>> index d99127dc466e..3bebb6c37604 100644
>> --- a/drivers/net/wireless/marvell/mwifiex/main.c
>> +++ b/drivers/net/wireless/marvell/mwifiex/main.c
>> @@ -802,6 +802,10 @@ mwifiex_bypass_tx_queue(struct mwifiex_private *priv,
>>  			    "bypass txqueue; eth type %#x, mgmt %d\n",
>>  			     ntohs(eth_hdr->h_proto),
>>  			     mwifiex_is_skb_mgmt_frame(skb));
>> +		if (ntohs(eth_hdr->h_proto) == ETH_P_PAE)
>> +			mwifiex_dbg(priv->adapter, MSG,
>> +				    "key: send EAPOL to %pM\n",
>> +				    eth_hdr->h_dest);
> 
> this is just debug code, at a first glance not sure i

not only that, the usual pattern is:
if (eth_hdr->h_proto == htons(ETH_P_PAE))

you want to do endian conversion on a constant when possible since that
is a compile-time conversion and not a runtime conversion