linux-kernel - Re: [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <083d318a-48b2-47f0-aed0-8788e25138f4@redhat.com>
Date:   Sat, 2 Dec 2023 12:32:14 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        SungHwan Jung <onenowy@...il.com>
Cc:     platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE

Hi,

On 11/30/23 14:00, Ilpo Järvinen wrote:
> On Thu, 30 Nov 2023, SungHwan Jung wrote:
> 
>> select ACPI_PLATFORM_PROFILE to fix the dependency problem for acer-wmi
>> to support platform profile.
>>
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202311301842.ppdT4zWK-lkp@intel.com/
>>
>> Signed-off-by: SungHwan Jung <onenowy@...il.com>
>>
>> ---
>> I apologize that I missed dependency in kconfig.
>> I have submitted a single patch because the series of patches were alreay
>> merged to linux-next.
>> Is this enough or should I re-submit the patch-series including this patch?
>> (or modify this to apply before "platform/x86: acer-wmi: Add platform
>> profile and modekey support for Predator PHN16-71" commit?)
>> ---
>>  drivers/platform/x86/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 8e99a2f10147..81e6cd62a533 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -182,6 +182,7 @@ config ACER_WMI
>>  	select INPUT_SPARSEKMAP
>>  	select LEDS_CLASS
>>  	select NEW_LEDS
>> +	select ACPI_PLATFORM_PROFILE
>>  	help
>>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
>>  	  wireless radio and bluetooth control, and on some laptops,
>>
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> I suspect Hans will just included that into the original patch so this 
> patch will not appear in the history at all.

Right.

Thank you both for the patch and the review.

I have squashed this change into the original patch introducing
the platform_profile support.

You can find the new version in my pdx86/review-hans branch and the
pdx86/for-next branch now.

Regards,

Hans