linux-kernel - Re: [PATCH v3 2/5] w1: ds2433: remove unused definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50dfe882-89b8-4fe9-8140-784d322c1385@kernel.org>
Date:   Sat, 2 Dec 2023 13:02:45 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     marc.ferland@...il.com, krzysztof.kozlowski@...aro.org
Cc:     gregkh@...uxfoundation.org, marc.ferland@...atest.com,
        jeff.dagenais@...il.com, rdunlap@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] w1: ds2433: remove unused definition

On 30/11/2023 14:52, marc.ferland@...il.com wrote:
> From: Marc Ferland <marc.ferland@...atest.com>
> 
> W1_F23_TIME isn't used anywhere, get rid of it.
> 
> Signed-off-by: Marc Ferland <marc.ferland@...atest.com>
> ---
>  drivers/w1/slaves/w1_ds2433.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
> index 9f21fd98f799..e18523ef8c45 100644
> --- a/drivers/w1/slaves/w1_ds2433.c
> +++ b/drivers/w1/slaves/w1_ds2433.c
> @@ -30,8 +30,6 @@
>  #define W1_PAGE_BITS		5
>  #define W1_PAGE_MASK		0x1F
>  
> -#define W1_F23_TIME		300

Same for W1_PAGE_COUNT and, so is there a point to keep it?

Best regards,
Krzysztof