linux-kernel - Re: [PATCH] hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b76e7b5-a693-41e9-bf8c-531735c57337@roeck-us.net>
Date:   Sat, 2 Dec 2023 07:42:25 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Aleksa Savic <savicaleksa83@...il.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: Add driver for Gigabyte AORUS Waterforce AIO
 coolers

On 12/2/23 07:01, Aleksa Savic wrote:
> On 2023-10-20 15:02:08 GMT+02:00, Aleksa Savic wrote:
>> This driver exposes hardware sensors of the Gigabyte AORUS Waterforce
>> all-in-one CPU liquid coolers, which communicate through a proprietary
>> USB HID protocol. Report offsets were initially discovered in [1] and
>> confirmed by me on a Waterforce X240 by observing the sent reports from
>> the official software.
>>
>> Available sensors are pump and fan speed in RPM, as well as coolant
>> temperature. Also available through debugfs is the firmware version.
>>
>> Attaching a fan is optional and allows it to be controlled from the
>> device. If it's not connected, the fan-related sensors will report
>> zeroes.
>>
>> The addressable RGB LEDs and LCD screen are not supported in this
>> driver and should be controlled through userspace tools.
>>
>> [1]: https://github.com/liquidctl/liquidctl/issues/167
>>
>> Signed-off-by: Aleksa Savic <savicaleksa83@...il.com>
>> ---
>>   Documentation/hwmon/gigabyte_waterforce.rst |  47 +++
>>   MAINTAINERS                                 |   7 +
>>   drivers/hwmon/Kconfig                       |  10 +
>>   drivers/hwmon/Makefile                      |   1 +
>>   drivers/hwmon/gigabyte_waterforce.c         | 439 ++++++++++++++++++++
>>   5 files changed, 504 insertions(+)
>>   create mode 100644 Documentation/hwmon/gigabyte_waterforce.rst
>>   create mode 100644 drivers/hwmon/gigabyte_waterforce.c
> 
> Hi Guenter,
> 
> Any thoughts on the patch? I'll fix the issues kernel bot reported
> in v2.
> 

I was waiting for that. In general, I am too busy to review patches if
0-day reports a problem, and wait for those to be resolved.

Guenter