linux-kernel - Re: [PATCH 2/2] x86/microcode: Rework early revisions reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWu/O9XeMBfbs3H7@a4bf019067fa.jf.intel.com>
Date:   Sat, 2 Dec 2023 15:35:23 -0800
From:   Ashok Raj <ashok.raj@...el.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH 2/2] x86/microcode: Rework early revisions reporting

On Sat, Dec 02, 2023 at 05:38:50PM +0100, Borislav Petkov wrote:
> On Fri, Dec 01, 2023 at 01:32:37PM -0800, Ashok Raj wrote:
> > dmesg for the microcode part here below:
> > 
> > https://paste.debian.net/hidden/e911dffc/
> 
> Thanks, it is all clear now.
> 
> This should fix it:

Yes, this works as expected.

> 
> ---
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> Date: Fri, 1 Dec 2023 14:35:06 +0100
> Subject: [PATCH] x86/microcode/intel: Set new revision only after a successful update
> 
> This was meant to be done only when early microcode got updated
> successfully. Move it into the if-branch.
> 
> Also, make sure the current revision is read unconditionally and only
> once.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>

Tested-by: Ashok Raj <ashok.raj@...el.com>