lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <00568ba8c40d034bfe6ba08f25b114f2b2955308.camel@mediatek.com> Date: Sat, 2 Dec 2023 02:04:59 +0000 From: Wenbin Mei (梅文彬) <Wenbin.Mei@...iatek.com> To: "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>, "treapking@...omium.org" <treapking@...omium.org>, "angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com>, Chaotian Jing (井朝天) <Chaotian.Jing@...iatek.com> CC: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>, "wenst@...omium.org" <wenst@...omium.org>, "ot_shunxi.zhang@...iatek.corp-partner.google.com" <ot_shunxi.zhang@...iatek.corp-partner.google.com>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org> Subject: Re: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data On Fri, 2023-12-01 at 18:26 +0800, Pin-yen Lin wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > This log message is necessary for debugging, so enable it by default > to > debug issues that are hard to reproduce locally. > > Signed-off-by: Pin-yen Lin <treapking@...omium.org> > Reviewed-by: Wenbin Mei <wenbin.mei@...iatek.com> > --- > > Changes in v3: > - Only print the warning when -ETIMEDOUT or not in tuning process > > Changes in v2: > - Use dev_warn() instead of dev_err() > > drivers/mmc/host/mtk-sd.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 97f7c3d4be6e..6ae5e0a9fca9 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct > msdc_host *host) > > static void msdc_track_cmd_data(struct msdc_host *host, struct > mmc_command *cmd) > { > - if (host->error) > - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host- > >error=0x%08X\n", > - __func__, cmd->opcode, cmd->arg, host->error); > + if (host->error && > + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) || > + cmd->error == -ETIMEDOUT)) > + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host- > >error=0x%08X\n", > + __func__, cmd->opcode, cmd->arg, host->error); > } > > static void msdc_request_done(struct msdc_host *host, struct > mmc_request *mrq) > -- > 2.43.0.rc2.451.g8631bc7472-goog >
Powered by blists - more mailing lists