linux-kernel - Re: [PATCH -next] ksmbd: fix memory leak in smb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd-6AfN8PUZWafHHg8xeH+7T5CLFtjs+4Snb=smiDHJgqQ@mail.gmail.com>
Date:   Sat, 2 Dec 2023 12:54:30 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Zizhi Wo <wozizhi@...wei.com>
Cc:     sfrench@...ba.org, senozhatsky@...omium.org, lsahlber@...hat.com,
        hyc.lee@...il.com, linux-cifs@...r.kernel.org,
        linux-kernel@...r.kernel.org, yangerkun@...wei.com
Subject: Re: [PATCH -next] ksmbd: fix memory leak in smb2_lock()

2023-12-01 23:50 GMT+09:00, Zizhi Wo <wozizhi@...wei.com>:
> In smb2_lock(), if setup_async_work() executes successfully,
> work->cancel_argv will bind the argv that generated by kmalloc(). And
> release_async_work() is called in ksmbd_conn_try_dequeue_request() or
> smb2_lock() to release argv.
> However, when setup_async_work function fails, work->cancel_argv has not
> been bound to the argv, resulting in the previously allocated argv not
> being released. Call kfree() to fix it.
>
> when setup_async_work fails, the code will go to the
> "out" branch, resulting in the previously allocated "argv" not being
> released. Call kfree() to fix it.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Signed-off-by: Zizhi Wo <wozizhi@...wei.com>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Applied it to #ksmbd-for-next-next .
Thanks.