linux-kernel - Re: [PATCH v2 2/6] twl-core: add power off implementation for twl603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231203221605.38496a8d@aktux>
Date:   Sun, 3 Dec 2023 22:16:05 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Lee Jones <lee@...nel.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, bcousson@...libre.com, tony@...mide.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 2/6] twl-core: add power off implementation for
 twl603x

On Fri, 1 Dec 2023 10:48:20 +0000
Lee Jones <lee@...nel.org> wrote:

> > +	if (err) {
> > +		pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);  
> 
> It would save an awful lot of lines and space if we could place these
> warnings/errors inside twl_i2c_read_u8().

Well, it is already in twl_i2c_read() ...
yes, we can save quite some lines.

Regards,
Andreas