linux-kernel - Re: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231203220626.ild5flvaqvlsqbmy@zenone.zhora.eu>
Date:   Sun, 3 Dec 2023 23:06:26 +0100
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@....com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe()

Hi Andy,

On Thu, Nov 30, 2023 at 03:28:18PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 30, 2023 at 12:21:51AM +0100, Andi Shyti wrote:
> > Hi Andy,
> > 
> > On Mon, Nov 20, 2023 at 04:42:01PM +0200, Andy Shevchenko wrote:
> > > Since i2c_dw_probe() is going to be extended, uninline it to reduce
> > > the noise in the common header.
> > 
> > where is it going to be extended? It's not in thie series. I'm
> > fine with the patch anyway as it cleans up the header file.
> 
> It's used to be in the previous versions of the series where I have
> device_set_node() API to be used.

Thanks! I think this missed:

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Andi