lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202312021710.3blFSIKX-lkp@intel.com>
Date:   Sun, 3 Dec 2023 14:07:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: drivers/cpufreq/powernv-cpufreq.c:469:25: sparse: sparse: restricted
 __be64 degrades to integer

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   815fb87b753055df2d9e50f6cd80eb10235fe3e9
commit: cb166fa937a2fbc14badcafca86202354c34a213 cpufreq: powernv: Register for OCC related opal_message notification
date:   8 years ago
config: powerpc64-randconfig-r113-20231107 (https://download.01.org/0day-ci/archive/20231202/202312021710.3blFSIKX-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231202/202312021710.3blFSIKX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312021710.3blFSIKX-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   drivers/cpufreq/powernv-cpufreq.c:175:18: sparse: sparse: symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should it be static?
   drivers/cpufreq/powernv-cpufreq.c:436:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be64 [usertype] type @@     got unsigned long long @@
   drivers/cpufreq/powernv-cpufreq.c:436:19: sparse:     expected restricted __be64 [usertype] type
   drivers/cpufreq/powernv-cpufreq.c:436:19: sparse:     got unsigned long long
   drivers/cpufreq/powernv-cpufreq.c:458:27: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be64 [usertype] chip @@     got unsigned long long @@
   drivers/cpufreq/powernv-cpufreq.c:458:27: sparse:     expected restricted __be64 [usertype] chip
   drivers/cpufreq/powernv-cpufreq.c:458:27: sparse:     got unsigned long long
   drivers/cpufreq/powernv-cpufreq.c:459:38: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be64 [usertype] throttle_status @@     got unsigned long long @@
   drivers/cpufreq/powernv-cpufreq.c:459:38: sparse:     expected restricted __be64 [usertype] throttle_status
   drivers/cpufreq/powernv-cpufreq.c:459:38: sparse:     got unsigned long long
>> drivers/cpufreq/powernv-cpufreq.c:469:25: sparse: sparse: restricted __be64 degrades to integer
   drivers/cpufreq/powernv-cpufreq.c:470:25: sparse: sparse: cast from restricted __be64
   drivers/cpufreq/powernv-cpufreq.c:470:25: sparse: sparse: restricted __be64 degrades to integer
   drivers/cpufreq/powernv-cpufreq.c:474:25: sparse: sparse: cast from restricted __be64
   drivers/cpufreq/powernv-cpufreq.c:474:25: sparse: sparse: restricted __be64 degrades to integer
   drivers/cpufreq/powernv-cpufreq.c:438:21: sparse: sparse: restricted __be64 degrades to integer
   drivers/cpufreq/powernv-cpufreq.c:438:21: sparse: sparse: restricted __be64 degrades to integer
   drivers/cpufreq/powernv-cpufreq.c: In function 'powernv_cpufreq_throttle_check':
   drivers/cpufreq/powernv-cpufreq.c:318:33: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
     318 |                 if (chips[i].id == cpu_to_chip_id(cpu))
         |                                 ^~
   In file included from include/linux/rcupdate.h:40,
                    from include/linux/idr.h:18,
                    from include/linux/kernfs.h:14,
                    from include/linux/sysfs.h:15,
                    from drivers/cpufreq/powernv-cpufreq.c:23:
   drivers/cpufreq/powernv-cpufreq.c: In function 'init_chip_info':
   include/linux/cpumask.h:221:23: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
     221 |                 (cpu) < nr_cpu_ids;)
         |                       ^
   include/linux/cpumask.h:714:36: note: in expansion of macro 'for_each_cpu'
     714 | #define for_each_possible_cpu(cpu) for_each_cpu((cpu), cpu_possible_mask)
         |                                    ^~~~~~~~~~~~
   drivers/cpufreq/powernv-cpufreq.c:511:9: note: in expansion of macro 'for_each_possible_cpu'
     511 |         for_each_possible_cpu(cpu) {
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/cpufreq/powernv-cpufreq.c:524:23: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
     524 |         for (i = 0; i < nr_chips; i++) {
         |                       ^

vim +469 drivers/cpufreq/powernv-cpufreq.c

   417	
   418	static char throttle_reason[][30] = {
   419						"No throttling",
   420						"Power Cap",
   421						"Processor Over Temperature",
   422						"Power Supply Failure",
   423						"Over Current",
   424						"OCC Reset"
   425					     };
   426	
   427	static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
   428					   unsigned long msg_type, void *_msg)
   429	{
   430		struct opal_msg *msg = _msg;
   431		struct opal_occ_msg omsg;
   432	
   433		if (msg_type != OPAL_MSG_OCC)
   434			return 0;
   435	
 > 436		omsg.type = be64_to_cpu(msg->params[0]);
   437	
   438		switch (omsg.type) {
   439		case OCC_RESET:
   440			occ_reset = true;
   441			/*
   442			 * powernv_cpufreq_throttle_check() is called in
   443			 * target() callback which can detect the throttle state
   444			 * for governors like ondemand.
   445			 * But static governors will not call target() often thus
   446			 * report throttling here.
   447			 */
   448			if (!throttled) {
   449				throttled = true;
   450				pr_crit("CPU Frequency is throttled\n");
   451			}
   452			pr_info("OCC: Reset\n");
   453			break;
   454		case OCC_LOAD:
   455			pr_info("OCC: Loaded\n");
   456			break;
   457		case OCC_THROTTLE:
   458			omsg.chip = be64_to_cpu(msg->params[1]);
   459			omsg.throttle_status = be64_to_cpu(msg->params[2]);
   460	
   461			if (occ_reset) {
   462				occ_reset = false;
   463				throttled = false;
   464				pr_info("OCC: Active\n");
   465				return 0;
   466			}
   467	
   468			if (omsg.throttle_status &&
 > 469			    omsg.throttle_status <= OCC_MAX_THROTTLE_STATUS)
   470				pr_info("OCC: Chip %u Pmax reduced due to %s\n",
   471					(unsigned int)omsg.chip,
   472					throttle_reason[omsg.throttle_status]);
   473			else if (!omsg.throttle_status)
   474				pr_info("OCC: Chip %u %s\n", (unsigned int)omsg.chip,
   475					throttle_reason[omsg.throttle_status]);
   476		}
   477		return 0;
   478	}
   479	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists