lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202312031347.MCbdZh7n-lkp@intel.com>
Date:   Sun, 3 Dec 2023 14:32:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/acpi/sleep.c:1208: warning: Function parameter or member
 'stage' not described in 'acpi_hibernation_begin_old'

Hi Rafael,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   968f35f4ab1c0966ceb39af3c89f2e24afedf878
commit: bb1869012d7b78d1474808cb4c8bd8b272645876 ACPI: PM: Call pm_set_suspend_via_firmware() during hibernation
date:   4 years, 6 months ago
config: x86_64-randconfig-r015-20230805 (https://download.01.org/0day-ci/archive/20231203/202312031347.MCbdZh7n-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231203/202312031347.MCbdZh7n-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312031347.MCbdZh7n-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/acpi/sleep.c:424: warning: expecting prototype for acpi_pre_suspend(). Prototype was for acpi_pm_pre_suspend() instead
   drivers/acpi/sleep.c:516: warning: Function parameter or member 'acpi_state' not described in 'acpi_pm_start'
   drivers/acpi/sleep.c:555: warning: Function parameter or member 'pm_state' not described in 'acpi_suspend_begin'
   drivers/acpi/sleep.c:682: warning: Function parameter or member 'pm_state' not described in 'acpi_suspend_begin_old'
>> drivers/acpi/sleep.c:1208: warning: Function parameter or member 'stage' not described in 'acpi_hibernation_begin_old'


vim +1208 drivers/acpi/sleep.c

caea99ef339af8 drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-01-08  1200  
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1201  /**
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1202   *	acpi_hibernation_begin_old - Set the target system sleep state to
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1203   *		ACPI_STATE_S4 and execute the _PTS control method.  This
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1204   *		function is used if the pre-ACPI 2.0 suspend ordering has been
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1205   *		requested.
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1206   */
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1207  static int acpi_hibernation_begin_old(pm_message_t stage)
a634cc10164d1c drivers/acpi/sleep/main.c Rafael J. Wysocki 2007-07-19 @1208  {
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1209  	int error;
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1210  	/*
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1211  	 * The _TTS object should always be evaluated before the _PTS object.
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1212  	 * When the old_suspended_ordering is true, the _PTS object is
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1213  	 * evaluated in the acpi_sleep_prepare.
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1214  	 */
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1215  	acpi_sleep_tts_switch(ACPI_STATE_S4);
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1216  
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui        2008-08-12  1217  	error = acpi_sleep_prepare(ACPI_STATE_S4);
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1218  	if (error)
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1219  		return error;
a634cc10164d1c drivers/acpi/sleep/main.c Rafael J. Wysocki 2007-07-19  1220  
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1221  	if (!nvs_nosave) {
dd4c4f17d722ff drivers/acpi/sleep.c      Matthew Garrett   2010-05-28  1222  		error = suspend_nvs_alloc();
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1223  		if (error)
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1224  			return error;
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1225  	}
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1226  
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1227  	if (stage.event == PM_EVENT_HIBERNATE)
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1228  		pm_set_suspend_via_firmware();
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1229  
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12  1230  	acpi_target_sleep_state = ACPI_STATE_S4;
ad07277e82deda drivers/acpi/sleep.c      Rafael J. Wysocki 2013-08-20  1231  	acpi_scan_lock_acquire();
bb1869012d7b78 drivers/acpi/sleep.c      Rafael J. Wysocki 2019-05-16  1232  	return 0;
3f4b0ef7f2899c drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-10-26  1233  }
3f4b0ef7f2899c drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-10-26  1234  

:::::: The code at line 1208 was first introduced by commit
:::::: a634cc10164d1c229fbeca33923e6a0ed939e894 swsusp: introduce restore platform operations

:::::: TO: Rafael J. Wysocki <rjw@...k.pl>
:::::: CC: Linus Torvalds <torvalds@...dy.linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists