| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202312040745.aXNIDAPv-lkp@intel.com>
Date: Mon, 4 Dec 2023 08:14:38 +0800
From: kernel test robot <lkp@...el.com>
To: Miklos Szeredi <mszeredi@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/fuse/cuse.c:318: warning: Function parameter or member 'args' not
described in 'cuse_process_init_reply'
Hi Miklos,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
commit: b50ef7c52ad7c954b743cd1cb181e9bf03537bab cuse: convert init to simple api
date: 4 years, 3 months ago
config: x86_64-randconfig-r015-20230805 (https://download.01.org/0day-ci/archive/20231204/202312040745.aXNIDAPv-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231204/202312040745.aXNIDAPv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312040745.aXNIDAPv-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/fuse/cuse.c:271: warning: expecting prototype for cuse_parse_dev_info(). Prototype was for cuse_parse_devinfo() instead
fs/fuse/cuse.c:318: warning: Function parameter or member 'fc' not described in 'cuse_process_init_reply'
>> fs/fuse/cuse.c:318: warning: Function parameter or member 'args' not described in 'cuse_process_init_reply'
>> fs/fuse/cuse.c:318: warning: Function parameter or member 'error' not described in 'cuse_process_init_reply'
vim +318 fs/fuse/cuse.c
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 308
151060ac131442 Tejun Heo 2009-04-14 309 /**
151060ac131442 Tejun Heo 2009-04-14 310 * cuse_process_init_reply - finish initializing CUSE channel
151060ac131442 Tejun Heo 2009-04-14 311 *
151060ac131442 Tejun Heo 2009-04-14 312 * This function creates the character device and sets up all the
151060ac131442 Tejun Heo 2009-04-14 313 * required data structures for it. Please read the comment at the
151060ac131442 Tejun Heo 2009-04-14 314 * top of this file for high level overview.
151060ac131442 Tejun Heo 2009-04-14 315 */
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 316 static void cuse_process_init_reply(struct fuse_conn *fc,
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 317 struct fuse_args *args, int error)
151060ac131442 Tejun Heo 2009-04-14 @318 {
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 319 struct cuse_init_args *ia = container_of(args, typeof(*ia), ap.args);
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 320 struct fuse_args_pages *ap = &ia->ap;
30783587b0f318 David Herrmann 2012-11-17 321 struct cuse_conn *cc = fc_to_cc(fc), *pos;
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 322 struct cuse_init_out *arg = &ia->out;
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 323 struct page *page = ap->pages[0];
151060ac131442 Tejun Heo 2009-04-14 324 struct cuse_devinfo devinfo = { };
151060ac131442 Tejun Heo 2009-04-14 325 struct device *dev;
151060ac131442 Tejun Heo 2009-04-14 326 struct cdev *cdev;
151060ac131442 Tejun Heo 2009-04-14 327 dev_t devt;
30783587b0f318 David Herrmann 2012-11-17 328 int rc, i;
151060ac131442 Tejun Heo 2009-04-14 329
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 330 if (error || arg->major != FUSE_KERNEL_VERSION || arg->minor < 11)
151060ac131442 Tejun Heo 2009-04-14 331 goto err;
151060ac131442 Tejun Heo 2009-04-14 332
151060ac131442 Tejun Heo 2009-04-14 333 fc->minor = arg->minor;
151060ac131442 Tejun Heo 2009-04-14 334 fc->max_read = max_t(unsigned, arg->max_read, 4096);
151060ac131442 Tejun Heo 2009-04-14 335 fc->max_write = max_t(unsigned, arg->max_write, 4096);
151060ac131442 Tejun Heo 2009-04-14 336
151060ac131442 Tejun Heo 2009-04-14 337 /* parse init reply */
151060ac131442 Tejun Heo 2009-04-14 338 cc->unrestricted_ioctl = arg->flags & CUSE_UNRESTRICTED_IOCTL;
151060ac131442 Tejun Heo 2009-04-14 339
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 340 rc = cuse_parse_devinfo(page_address(page), ap->args.out_args[1].size,
151060ac131442 Tejun Heo 2009-04-14 341 &devinfo);
151060ac131442 Tejun Heo 2009-04-14 342 if (rc)
151060ac131442 Tejun Heo 2009-04-14 343 goto err;
151060ac131442 Tejun Heo 2009-04-14 344
151060ac131442 Tejun Heo 2009-04-14 345 /* determine and reserve devt */
151060ac131442 Tejun Heo 2009-04-14 346 devt = MKDEV(arg->dev_major, arg->dev_minor);
151060ac131442 Tejun Heo 2009-04-14 347 if (!MAJOR(devt))
151060ac131442 Tejun Heo 2009-04-14 348 rc = alloc_chrdev_region(&devt, MINOR(devt), 1, devinfo.name);
151060ac131442 Tejun Heo 2009-04-14 349 else
151060ac131442 Tejun Heo 2009-04-14 350 rc = register_chrdev_region(devt, 1, devinfo.name);
151060ac131442 Tejun Heo 2009-04-14 351 if (rc) {
f2294482ff65dd Kirill Smelkov 2019-03-27 352 pr_err("failed to register chrdev region\n");
151060ac131442 Tejun Heo 2009-04-14 353 goto err;
151060ac131442 Tejun Heo 2009-04-14 354 }
151060ac131442 Tejun Heo 2009-04-14 355
151060ac131442 Tejun Heo 2009-04-14 356 /* devt determined, create device */
151060ac131442 Tejun Heo 2009-04-14 357 rc = -ENOMEM;
151060ac131442 Tejun Heo 2009-04-14 358 dev = kzalloc(sizeof(*dev), GFP_KERNEL);
151060ac131442 Tejun Heo 2009-04-14 359 if (!dev)
151060ac131442 Tejun Heo 2009-04-14 360 goto err_region;
151060ac131442 Tejun Heo 2009-04-14 361
151060ac131442 Tejun Heo 2009-04-14 362 device_initialize(dev);
151060ac131442 Tejun Heo 2009-04-14 363 dev_set_uevent_suppress(dev, 1);
151060ac131442 Tejun Heo 2009-04-14 364 dev->class = cuse_class;
151060ac131442 Tejun Heo 2009-04-14 365 dev->devt = devt;
151060ac131442 Tejun Heo 2009-04-14 366 dev->release = cuse_gendev_release;
151060ac131442 Tejun Heo 2009-04-14 367 dev_set_drvdata(dev, cc);
151060ac131442 Tejun Heo 2009-04-14 368 dev_set_name(dev, "%s", devinfo.name);
151060ac131442 Tejun Heo 2009-04-14 369
30783587b0f318 David Herrmann 2012-11-17 370 mutex_lock(&cuse_lock);
30783587b0f318 David Herrmann 2012-11-17 371
30783587b0f318 David Herrmann 2012-11-17 372 /* make sure the device-name is unique */
30783587b0f318 David Herrmann 2012-11-17 373 for (i = 0; i < CUSE_CONNTBL_LEN; ++i) {
30783587b0f318 David Herrmann 2012-11-17 374 list_for_each_entry(pos, &cuse_conntbl[i], list)
30783587b0f318 David Herrmann 2012-11-17 375 if (!strcmp(dev_name(pos->dev), dev_name(dev)))
30783587b0f318 David Herrmann 2012-11-17 376 goto err_unlock;
30783587b0f318 David Herrmann 2012-11-17 377 }
30783587b0f318 David Herrmann 2012-11-17 378
151060ac131442 Tejun Heo 2009-04-14 379 rc = device_add(dev);
151060ac131442 Tejun Heo 2009-04-14 380 if (rc)
30783587b0f318 David Herrmann 2012-11-17 381 goto err_unlock;
151060ac131442 Tejun Heo 2009-04-14 382
151060ac131442 Tejun Heo 2009-04-14 383 /* register cdev */
151060ac131442 Tejun Heo 2009-04-14 384 rc = -ENOMEM;
151060ac131442 Tejun Heo 2009-04-14 385 cdev = cdev_alloc();
151060ac131442 Tejun Heo 2009-04-14 386 if (!cdev)
30783587b0f318 David Herrmann 2012-11-17 387 goto err_unlock;
151060ac131442 Tejun Heo 2009-04-14 388
151060ac131442 Tejun Heo 2009-04-14 389 cdev->owner = THIS_MODULE;
151060ac131442 Tejun Heo 2009-04-14 390 cdev->ops = &cuse_frontend_fops;
151060ac131442 Tejun Heo 2009-04-14 391
151060ac131442 Tejun Heo 2009-04-14 392 rc = cdev_add(cdev, devt, 1);
151060ac131442 Tejun Heo 2009-04-14 393 if (rc)
151060ac131442 Tejun Heo 2009-04-14 394 goto err_cdev;
151060ac131442 Tejun Heo 2009-04-14 395
151060ac131442 Tejun Heo 2009-04-14 396 cc->dev = dev;
151060ac131442 Tejun Heo 2009-04-14 397 cc->cdev = cdev;
151060ac131442 Tejun Heo 2009-04-14 398
151060ac131442 Tejun Heo 2009-04-14 399 /* make the device available */
151060ac131442 Tejun Heo 2009-04-14 400 list_add(&cc->list, cuse_conntbl_head(devt));
8ce03fd76d3235 David Herrmann 2012-11-17 401 mutex_unlock(&cuse_lock);
151060ac131442 Tejun Heo 2009-04-14 402
151060ac131442 Tejun Heo 2009-04-14 403 /* announce device availability */
151060ac131442 Tejun Heo 2009-04-14 404 dev_set_uevent_suppress(dev, 0);
151060ac131442 Tejun Heo 2009-04-14 405 kobject_uevent(&dev->kobj, KOBJ_ADD);
151060ac131442 Tejun Heo 2009-04-14 406 out:
b50ef7c52ad7c9 Miklos Szeredi 2019-09-10 407 kfree(ia);
151060ac131442 Tejun Heo 2009-04-14 408 __free_page(page);
151060ac131442 Tejun Heo 2009-04-14 409 return;
151060ac131442 Tejun Heo 2009-04-14 410
151060ac131442 Tejun Heo 2009-04-14 411 err_cdev:
151060ac131442 Tejun Heo 2009-04-14 412 cdev_del(cdev);
30783587b0f318 David Herrmann 2012-11-17 413 err_unlock:
30783587b0f318 David Herrmann 2012-11-17 414 mutex_unlock(&cuse_lock);
151060ac131442 Tejun Heo 2009-04-14 415 put_device(dev);
151060ac131442 Tejun Heo 2009-04-14 416 err_region:
151060ac131442 Tejun Heo 2009-04-14 417 unregister_chrdev_region(devt, 1);
151060ac131442 Tejun Heo 2009-04-14 418 err:
eb98e3bdf3aa7b Miklos Szeredi 2019-01-24 419 fuse_abort_conn(fc);
151060ac131442 Tejun Heo 2009-04-14 420 goto out;
151060ac131442 Tejun Heo 2009-04-14 421 }
151060ac131442 Tejun Heo 2009-04-14 422
:::::: The code at line 318 was first introduced by commit
:::::: 151060ac13144208bd7601d17e4c92c59b98072f CUSE: implement CUSE - Character device in Userspace
:::::: TO: Tejun Heo <tj@...nel.org>
:::::: CC: Miklos Szeredi <mszeredi@...e.cz>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists