linux-kernel - Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c0d0ad2-b814-47b1-80e9-28ad62af6476@linux.ibm.com>
Date:   Mon, 4 Dec 2023 12:51:49 -0500
From:   Tony Krowiak <akrowiak@...ux.ibm.com>
To:     Halil Pasic <pasic@...ux.ibm.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, jjherne@...ux.ibm.com,
        alex.williamson@...hat.com, borntraeger@...ux.ibm.com,
        kwankhede@...dia.com, frankja@...ux.ibm.com,
        imbrenda@...ux.ibm.com, david@...hat.com
Subject: Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset



On 12/4/23 07:10, Halil Pasic wrote:
> On Wed, 29 Nov 2023 09:35:24 -0500
> Tony Krowiak <akrowiak@...ux.ibm.com> wrote:
> 
>> In the current implementation, response code 01 (AP queue number not valid)
>> is handled as a default case along with other response codes returned from
>> a queue reset operation that are not handled specifically. Barring a bug,
>> response code 01 will occur only when a queue has been externally removed
>> from the host's AP configuration; nn this case, the queue must
>> be reset by the machine in order to avoid leaking crypto data if/when the
>> queue is returned to the host's configuration.
> 
> s/if\/when/at latest before/
> 
> I would argue that some of the cleanups need to happen before even 01 is
> reflected...

To what cleanups are you referring?

> 
> The code comments may also require a similar rewording. With that fixed:
> Reviewed-by: Halil Pasic <pasic@...ux.ibm.com>
> 
> Regards,
> Halil
> 
>> The response code 01 case
>> will be handled specifically by logging a WARN message followed by cleaning
>> up the IRQ resources.
>>
>> Signed-off-by: Tony Krowiak <akrowiak@...ux.ibm.com>