linux-kernel - Re: [PATCH] mmc: rpmb: do not force a retune before RPMB switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Dec 2023 19:10:05 +0100
From:   "Jorge Ramirez-Ortiz, Foundries" <jorge@...ndries.io>
To:     Christian Loehle <christian.loehle@....com>
Cc:     Jorge Ramirez-Ortiz <jorge@...ndries.io>, Avri.Altman@....com,
        adrian.hunter@...el.com, ulf.hansson@...aro.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: rpmb: do not force a retune before RPMB switch

On 04/12/23 17:52:24, Christian Loehle wrote:
> On 04/12/2023 17:22, Jorge Ramirez-Ortiz wrote:
> > Requesting a retune before switching to the RPMB partition has been
> > observed to cause CRC errors on the RPMB reads (-EILSEQ).
> >
> > Since RPMB reads can not be retried, the clients would be directly
> > affected by the errors.
> >
> > This commit disables the request prior to RPMB switching while allowing
> > the pause interface to still request a retune before the pause for other
> > use cases.
> >
> > This was verified with the sdhci-of-arasan driver (ZynqMP) configured
> > for HS200 using two separate eMMC cards (DG4064 and 064GB2). In both
> > cases, the error was easy to reproduce triggering every few tenths of
> > reads.
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@...ndries.io>
> > Acked-by: Avri Altman <avri.altman@....com>
>
> Is the difference between this mail and the previous one just Avri's Ack?
> No need to resend for every tag you receive.

oops, every project with its own little idiosyncrasies sometimes I get
confused (u-boot, optee, ssl, tf-a..) yes, sorry about it, no differences.