linux-kernel - Re: [RFC PATCH 12/42] iommufd: Introduce allocation data info and flag for KVM managed HWPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204182928.GL1493156@nvidia.com>
Date:   Mon, 4 Dec 2023 14:29:28 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Yan Zhao <yan.y.zhao@...el.com>
Cc:     iommu@...ts.linux.dev, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, alex.williamson@...hat.com,
        pbonzini@...hat.com, seanjc@...gle.com, joro@...tes.org,
        will@...nel.org, robin.murphy@....com, kevin.tian@...el.com,
        baolu.lu@...ux.intel.com, dwmw2@...radead.org, yi.l.liu@...el.com
Subject: Re: [RFC PATCH 12/42] iommufd: Introduce allocation data info and
 flag for KVM managed HWPT

On Sat, Dec 02, 2023 at 05:21:13PM +0800, Yan Zhao wrote:

> @@ -413,11 +422,13 @@ struct iommu_hwpt_arm_smmuv3 {
>   * @IOMMU_HWPT_DATA_NONE: no data
>   * @IOMMU_HWPT_DATA_VTD_S1: Intel VT-d stage-1 page table
>   * @IOMMU_HWPT_DATA_ARM_SMMUV3: ARM SMMUv3 Context Descriptor Table
> + * @IOMMU_HWPT_DATA_KVM: KVM managed stage-2 page table
>   */
>  enum iommu_hwpt_data_type {
>  	IOMMU_HWPT_DATA_NONE,
>  	IOMMU_HWPT_DATA_VTD_S1,
>  	IOMMU_HWPT_DATA_ARM_SMMUV3,
> +	IOMMU_HWPT_DATA_KVM,
>  };

Definately no, the HWPT_DATA is for the *driver* - it should not be
"kvm".

Add the kvm fd to the main structure

Jason