linux-kernel - Re: Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8db5b21fee0f0e547d89b2797b0f4cc40062339b.camel@sipsolutions.net>
Date:   Mon, 04 Dec 2023 19:34:49 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Marc MERLIN <marc@...lins.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        ilw@...ux.intel.com, "Paul E. McKenney" <paulmck@...nel.org>
Subject: Re: Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work
 / netlink in 6.4 and 6.6

On Mon, 2023-12-04 at 08:52 -0800, Marc MERLIN wrote:
> > 
> > So looks like bug in the 'igc' driver wrt. runtime PM locking.
> 
> Thank you for the analysis Johannes, I appreciate it. I'm at a spot
> where I have to return this laptop very soon if I can't get it working
> (or will get stuck with it, it's a temp one until I get my original P73
> fixed, and from the little I've seen the 3 year newer P17 with I 11th
> gen (10nm) instead of I 9th gen (14nm), there isn't a huge difference
> between the 2, especially as my I9 had 8 cores and the I11 only 6 cores.
> So I may go back to the P73 as soon as I can get it fixed).
> 
> In the meantime, anything I can try to get around that bug and confirm
> that assumption? I assume that driver isn't something I can turn off
> since everything depends on it, correct?
> 

Well I assume your ethernet connectivity depends on it :) If you don't
need that, I guess you can just blacklist it.

You could probably remove the runtime PM ops:

--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7321,8 +7321,6 @@ static const struct pci_error_handlers igc_err_handler = {
 #ifdef CONFIG_PM
 static const struct dev_pm_ops igc_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(igc_suspend, igc_resume)
-	SET_RUNTIME_PM_OPS(igc_runtime_suspend, igc_runtime_resume,
-			   igc_runtime_idle)
 };
 #endif
 

But I really have no idea about this driver, this is purely from reading
the stack dump and code.

johannes