linux-kernel - Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4877522.31r3eYUQgx@z3ntu.xyz>
Date:   Mon, 04 Dec 2023 19:41:48 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>
Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

On Montag, 4. Dezember 2023 10:46:49 CET Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@...il.com>
> ---
>  .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts    | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index
> f516e0426bb9..8a2ba2aadf23 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -268,6 +268,13 @@ touchscreen@4a {
>  		interrupt-parent = <&tlmm>;
>  		interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> 
> +		linux,keycodes = <KEY_RESERVED
> +				  KEY_RESERVED
> +				  KEY_RESERVED
> +				  KEY_RESERVED
> +				  KEY_APPSELECT
> +				  KEY_BACK>;

Might be prettier like this since it's 6 items you're adding, not one long 
property?

	linux,keycodes = <KEY_RESERVED>,
			  <KEY_RESERVED>,
			  <KEY_RESERVED>,
			  <KEY_RESERVED>,
			  <KEY_APPSELECT>,
			  <KEY_BACK>;

Resulting dtb should be the same, so it's just a stylistic thing.

In any case:

Reviewed-by: Luca Weiss <luca@...tu.xyz>

> +
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&tsp_int_rst_default_state>;