linux-kernel - Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+GBs23TzwMoRUSCNX60+FRLSm9KSv_T_prJUS=+9soCA@mail.gmail.com>
Date:   Mon, 4 Dec 2023 20:54:19 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     YangXin <yx.0xffff@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters

On Mon, Dec 4, 2023 at 7:59 PM YangXin <yx.0xffff@...il.com> wrote:
>
> key_eq() and hash() are functions of struct neigh_table, so we just need to call tbl->key_eq() and tbl->hash(), instead of passing them in as parameters.
>
> Signed-off-by: YangXin <yx.0xffff@...il.com>

Not sure, this might defeat inlining.