linux-kernel - Re: [Freedreno] [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <230fd6a4-c1d6-64af-1073-2effd5d44d8c@quicinc.com>
Date:   Mon, 4 Dec 2023 12:25:16 -0800
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        "Sean Paul" <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David Airlie" <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>,
        "Vinod Polimera" <quic_vpolimer@...cinc.com>,
        Stephen Boyd <swboyd@...omium.org>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <error27@...il.com>,
        <dan.carpenter@...aro.org>
Subject: Re: [Freedreno] [PATCH next] drm/msm/dp: add a missing unlock in
 dp_hpd_plug_handle()



On 12/4/2023 9:13 AM, Harshit Mogalapalli wrote:
> When pm_runtime_resume_and_get() fails, unlock before returning.
> 
> Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is based on static analysis with Smatch. Only compile tested.
> ---
>   drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>