linux-kernel - Re: [PATCH] x86/sev: Do the C-bit verification only on the BSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204221455.GFZW5PX/goIKpeYlwT@fat_crate.local>
Date:   Mon, 4 Dec 2023 23:14:55 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     X86 ML <x86@...nel.org>, Joerg Roedel <joro@...tes.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/sev: Do the C-bit verification only on the BSP

On Mon, Dec 04, 2023 at 10:06:42AM -0600, Tom Lendacky wrote:
> You're ignoring RAX now on return, so you can probably just make
> sev_verify_cbit() a void function now. You would still need to save RAX
> because of the calling convention, though, so it doesn't make this code any
> cleaner (other than the comment could then just say restore CR3 value).
> You're call, I'm good either way.

I'm thinking I should leave that change for the patch which converts
sev_verify_cbit() to C...

Thx for looking.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette