linux-kernel - Re: [PATCH v3] regulator: event: Add regulator netlink event support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0953578-1c61-4461-af07-8cf1e3d1837e@sirena.org.uk>
Date:   Mon, 4 Dec 2023 23:23:59 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Naresh Solanki <naresh.solanki@...ements.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] regulator: event: Add regulator netlink event support

On Tue, Nov 28, 2023 at 02:07:16PM +0000, Naresh Solanki wrote:
> This commit introduces netlink event support to the regulator subsystem.
> 
> Changes:
> - Introduce event.c and regnl.h for netlink event handling.
> - Implement reg_generate_netlink_event to broadcast regulator events.
> - Update Makefile to include the new event.c file.

This looks good however it breaks an allmodconfig build:

   ERROR: modpost: missing MODULE_LICENSE() in drivers/regulator/event.o

> +config REGULATOR_NETLINK_EVENTS
> +	tristate "Enable support for receiving regulator events via netlink"
> +	depends on NET

I think this needs to be a bool (NET is a bool so there's no dependency
issues there hopefully).

Thanks for pushing this forwards.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)