linux-kernel - Re: Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a726f38.19f2f.18c340249f7.Coremail.alexious@zju.edu.cn>
Date:   Mon, 4 Dec 2023 16:46:54 +0800 (GMT+08:00)
From:   alexious@....edu.cn
To:     Christian König <christian.koenig@....com>
Cc:     "Alex Deucher" <alexander.deucher@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "David Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "Jerome Glisse" <jglisse@...hat.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] drm/radeon/dpm: fix a memleak in
 sumo_parse_power_table

> Am 03.12.23 um 18:16 schrieb Zhipeng Lu:
> > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every
> > following error-handling path. However, in the error-handling of
> > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed,
> > resulting in a memleak in this function.
> >
> > Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for sumo asics (v2)")
> > Signed-off-by: Zhipeng Lu <alexious@....edu.cn>
> > ---
> >   drivers/gpu/drm/radeon/sumo_dpm.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/sumo_dpm.c b/drivers/gpu/drm/radeon/sumo_dpm.c
> > index f74f381af05f..bde640053708 100644
> > --- a/drivers/gpu/drm/radeon/sumo_dpm.c
> > +++ b/drivers/gpu/drm/radeon/sumo_dpm.c
> > @@ -1494,6 +1494,7 @@ static int sumo_parse_power_table(struct radeon_device *rdev)
> >   		non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *)
> >   			&non_clock_info_array->nonClockInfo[non_clock_array_index];
> >   		if (!rdev->pm.power_state[i].clock_info)
> > +			kfree(rdev->pm.dpm.ps);
> >   			return -EINVAL;
> 
> That change is obviously not correct since you now always return -EINVAL.
> 
> You need to at least add {} here.
> 

I'm sorry for my mistake and I'll send a new patch soon.

Regards,
Zhipeng