linux-kernel - Re: [PATCH v2 2/2] sched/fair: Simplify util

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtBcF=sL6O17Vq-zCwqp48LNN46oTG=Drs5=MEh=gbuxPw@mail.gmail.com>
Date:   Mon, 4 Dec 2023 10:54:28 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Qais Yousef <qyousef@...alina.io>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        corbet@....net, alexs@...nel.org, siyanteng@...ngson.cn,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        lukasz.luba@....com, hongyan.xia2@....com, yizhou.tang@...pee.com
Subject: Re: [PATCH v2 2/2] sched/fair: Simplify util_est

On Sun, 3 Dec 2023 at 00:38, Qais Yousef <qyousef@...alina.io> wrote:
>
> On 12/01/23 17:16, Vincent Guittot wrote:
>
> >  /*
> >   * The load/runnable/util_avg accumulates an infinite geometric series
> >   * (see __update_load_avg_cfs_rq() in kernel/sched/pelt.c).
> > @@ -505,9 +469,20 @@ struct sched_avg {
> >       unsigned long                   load_avg;
> >       unsigned long                   runnable_avg;
> >       unsigned long                   util_avg;
> > -     struct util_est                 util_est;
> > +     unsigned int                    util_est;
> >  } ____cacheline_aligned;
>
> unsigned long would be better?

I thought about changing it to unsigned long but I prefered to keep
using the same type as before for the ewma as we don't need to extend
it