linux-kernel - Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb1554d0-7a5e-4b1e-a8e7-bcfabad9b070@linaro.org>
Date:   Mon, 4 Dec 2023 10:55:37 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Robert Foss <rfoss@...nel.org>,
        Peter Ujfalusi <peter.ujfalusi@...il.com>,
        Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

On 04/12/2023 08:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A dependency on this feature was recently introduced:
> 
> x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
> tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'
> 
> Make sure this is always enabled.
> 
> Fixes: e5fb21678136 ("drm/bridge: tc358768: Use struct videomode")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/gpu/drm/bridge/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index ba82a1142adf..3e6a4e2044c0 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -313,6 +313,7 @@ config DRM_TOSHIBA_TC358768
>   	select REGMAP_I2C
>   	select DRM_PANEL
>   	select DRM_MIPI_DSI
> +	select VIDEOMODE_HELPERS
>   	help
>   	  Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver.
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>