linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8939: Add clock-frequency for broadcast timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f24e9f93-bd48-4845-96cb-ae08f8b4f210@linaro.org>
Date:   Mon, 4 Dec 2023 12:00:18 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Andy Gross <agross@...nel.org>, Shawn Guo <shawn.guo@...aro.org>,
        Benjamin Li <benl@...areup.com>,
        James Willcox <jwillcox@...areup.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Jun Nie <jun.nie@...aro.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8939: Add clock-frequency for
 broadcast timer

On 4.12.2023 10:55, Stephan Gerhold wrote:
> Looks like not all firmware versions used for MSM8939 program the timer
> frequency for both broadcast/MMIO timers, causing a WARNING at runtime:
> 
> WARNING: CPU: 0 PID: 0 at kernel/time/clockevents.c:38 cev_delta2ns+0x74/0x90
> pc : cev_delta2ns+0x74/0x90
> lr : clockevents_config.part.0+0x64/0x8c
> Call trace:
>  cev_delta2ns+0x74/0x90
>  clockevents_config_and_register+0x20/0x34
>  arch_timer_mem_of_init+0x374/0x534
>  timer_probe+0x88/0x110
>  time_init+0x14/0x4c
>  start_kernel+0x2c0/0x640
> 
> Unfortunately there is no way to fix the firmware on most of these
> devices since it's proprietary and signed. As a workaround, specify the
> clock-frequency explicitly in the DT to fix the warning.
> 
> Fixes: 61550c6c156c ("arm64: dts: qcom: Add msm8939 SoC")
> Reported-by: Vincent Knecht <vincent.knecht@...loo.org>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> ---
Ouch.

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad